Multiple fixes to Kafka, Consul, stdlib deprecations#404
Merged
Conversation
truthbk
commented
Mar 5, 2018
Member
Author
truthbk
left a comment
truthbk
left a comment
There was a problem hiding this comment.
Unilateral merge - tested on puppet 4/5
cegeka-jenkins
pushed a commit
to cegeka/puppet-datadog_agent
that referenced
this pull request
Apr 6, 2020
* [kafka] adding Agent6 support * [consul][spec] adding more extensive tests * [functions] remove legacy validations * [manifest] more stdlib 4.24.0 deprecation fixes * [agent6] fix tagging. * [legacy] fix tests for older rubies * [apt][metadata] dropping lower bound to 2.4.0 for increased compatibility * [functions] fix typo in tag6, use variable in recursion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
validate_legacy. In general we will move towards setting types for parameters, and we'll do so gradually, customers should not be affected by the changes, and the test suite should keep us honest.