Skip to content

Uninitialized HOSTNAME_EXTRACTION_REGEX when trying to report to datadog #442

@ColinHebert

Description

@ColinHebert

Hihi, I have the following error showing up when attempting to send a report to datadog (which ends up being an exception that kills the JVM)

puppet_1    | 2018-06-26 04:34:02,836 ERROR [puppetserver] Puppet Report processor failed: uninitialized constant HOSTNAME_EXTRACTION_REGEX
puppet_1    | org/jruby/RubyModule.java:2746:in `const_missing'
puppet_1    | /etc/puppetlabs/code/modules/datadog_agent/lib/puppet/reports/datadog_reports.rb:49:in `process'
puppet_1    | /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/indirector/report/processor.rb:37:in `process'
puppet_1    | /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/indirector/report/processor.rb:53:in `processors'
...
puppet_1    | jetty9_core.clj:433:in `invoke'
puppet_1    | normalized_uri_helpers.clj:74:in `invoke'

It looks like in datadog_reports.rb constants are used to contain things that may vary from one run to another.
This has lead to issues in the past (#292) and was fixed by adding more of those constants.

The problem is that now that second constant may not be initalised (because of the unless clause)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions