Skip to content

Avoid proliferation of constants and ensure they're initialised#443

Merged
truthbk merged 1 commit intoDataDog:masterfrom
ColinHebert:patch-2
Jul 10, 2018
Merged

Avoid proliferation of constants and ensure they're initialised#443
truthbk merged 1 commit intoDataDog:masterfrom
ColinHebert:patch-2

Conversation

@ColinHebert
Copy link
Copy Markdown
Contributor

@ColinHebert ColinHebert commented Jun 26, 2018

Fixes #442

@irabinovitch irabinovitch requested a review from truthbk June 26, 2018 05:07
@truthbk truthbk self-assigned this Jul 5, 2018
Copy link
Copy Markdown
Member

@truthbk truthbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you @ColinHebert 🙇

@truthbk
Copy link
Copy Markdown
Member

truthbk commented Jul 10, 2018

The CI issue has been fixed on master so we can just merge despite the known errored test runs.

@truthbk truthbk merged commit ba0f729 into DataDog:master Jul 10, 2018
@truthbk truthbk added this to the 2.3.0 milestone Jul 11, 2018
cegeka-jenkins pushed a commit to cegeka/puppet-datadog_agent that referenced this pull request Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants