Silence agent6_extra_options notification on default params#449
Merged
truthbk merged 2 commits intoDataDog:masterfrom Jul 18, 2018
Merged
Silence agent6_extra_options notification on default params#449truthbk merged 2 commits intoDataDog:masterfrom
truthbk merged 2 commits intoDataDog:masterfrom
Conversation
truthbk
approved these changes
Jul 18, 2018
Member
truthbk
left a comment
truthbk
left a comment
There was a problem hiding this comment.
Ugh, we got bit by the boolean behavior with on puppet 4+, my bad! Thank you very much for this 🙇 - we'll make this available in the next release (bugfix or minor not sure what will come first).
|
Thanx for this fix, we're encountering the same noise now 👍 |
cegeka-jenkins
pushed a commit
to cegeka/puppet-datadog_agent
that referenced
this pull request
Apr 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I updated to 2.3.0 of this module today (and just realized it was updated 2 days ago).
Since upgrading, I've had extraneous noise in my puppet run outputs that I tracked down to this.
The default values of these params is an empty string
'', which is interpreted by Puppet 4+ in boolean situations astrue, hence these notify's are firing even when those parameters aren't supplied. (https://puppet.com/docs/puppet/4.10/lang_updating_manifests.html#empty-strings-in-boolean-context-are-true)