[reports] make gem provider configurable at the datadog-agent class level.#486
Merged
[reports] make gem provider configurable at the datadog-agent class level.#486
Conversation
remicalixte
force-pushed
the
remicalixte/gem-provider
branch
2 times, most recently
from
5f53ccd to
b5e43fa
Compare
truthbk
reviewed
Jan 3, 2019
Member
truthbk
left a comment
truthbk
left a comment
There was a problem hiding this comment.
I know you mostly took this from the old PR I wrote. I think that old code could've been cleaner (whooops). Can we clean it up a bit? Other than that, I think this should address the serverless scenario problem. Thank you for taking care of this.
remicalixte
force-pushed
the
remicalixte/gem-provider
branch
from
b5e43fa to
e72af49
Compare
Contributor
Author
|
We should maybe add somewhere in the docs that one should use the |
Contributor
Author
|
Otherwise LGTM |
cegeka-jenkins
pushed a commit
to cegeka/puppet-datadog_agent
that referenced
this pull request
Apr 6, 2020
…evel. (DataDog#486) * [reports] make gem provider configurable at the datadog-agent class level. * Add default value for gem provider in report class * [reports] adding spec test for alternative gem providers + fix * [docs] adding note regarding gem provider for dogapi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.