Remove apt-transport-https package install#504
Merged
truthbk merged 3 commits intoDataDog:masterfrom Mar 22, 2019
wuakitv:master
Merged
Remove apt-transport-https package install#504truthbk merged 3 commits intoDataDog:masterfrom wuakitv:master
truthbk merged 3 commits intoDataDog:masterfrom
wuakitv:master
Conversation
truthbk
approved these changes
Mar 22, 2019
Member
truthbk
left a comment
truthbk
left a comment
There was a problem hiding this comment.
This is a nice addition, I've had to resolve some conflict after merging #506, but I think we're good, any additional fixes that might be necessary I will do in separate PRs.
Thank you for this, it's always nice to delegate this sort of thing on other modules, particularly officially supported ones 😄
Thanks again! 🙇
cegeka-jenkins
pushed a commit
to cegeka/puppet-datadog_agent
that referenced
this pull request
Apr 6, 2020
* removing noisy unnecessary exec * Requiring minimum version 4.4.0 (when apt-transport-https is installed)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
puppetlabs/apt4.4.0is already managed in theaptmodule.Also fixes #491