This repository was archived by the owner on Feb 9, 2024. It is now read-only.
W-7827284 fix from upstream, stop managing apt-transport-https#10
Merged
instantlinux merged 1 commit intokrux-masterfrom Jul 17, 2020
Merged
W-7827284 fix from upstream, stop managing apt-transport-https#10instantlinux merged 1 commit intokrux-masterfrom
instantlinux merged 1 commit intokrux-masterfrom
Conversation
dcrampton-sfdc
left a comment
There was a problem hiding this comment.
Why does this repo seem to have no checks?
Author
It was forked some time ago and we do not plan to do any dev on it. This PR just adopts a change from the upstream. Perhaps someone else can explain why we forked it. |
ghost
approved these changes
Jul 17, 2020
pkrohn-sfdc
approved these changes
Jul 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Cherry picks a change from the upstream: see DataDog#504; this removes management of apt-transport-https.
Motivation
Conflicts with our profile::base class which already manages this package. We want to clean up our puppet-agent runs so they aren't making "corrective changes" each time, so daily triage will pick up future unexpected changes.
Describe your test plan
Dev instances running on this branch now report no changes:
See also the https://puppet-ui-prod.krxd.net/#/inspect/overview dashboard for node reports.