remove spaces that break resulting yaml#336
Merged
truthbk merged 1 commit intoDataDog:masterfrom Jul 19, 2017
ckolos:master
Merged
remove spaces that break resulting yaml#336truthbk merged 1 commit intoDataDog:masterfrom ckolos:master
truthbk merged 1 commit intoDataDog:masterfrom
ckolos:master
Conversation
Contributor
Author
|
filed #337 |
truthbk
approved these changes
Jul 19, 2017
Member
truthbk
left a comment
There was a problem hiding this comment.
Thank you for fixing this! Merging! ![]()
cegeka-jenkins
pushed a commit
to cegeka/puppet-datadog_agent
that referenced
this pull request
Jan 31, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As written in master, the yaml produced by the docker_daemon.yaml.erb results in an agent stack trace on
configtest. After investigation, it seems that there are too many spaces being added in the tag: element and that results in invalid yaml.After application of patch and re-apply: