Added multiple postgres instances and fixed pgbouncer

[rothgar]

This fixes a problem with pgbouncer class not including the datadog_agent (error if not otherwise included)

It also allows multiple postgres instances on the same node. It's based on the mysql template and manifest but now can be applied to postgres.

[rothgar]

Just for reference/testing, here's an example to declare multiple postgres instances in hiera for a node

datadog_agent::integrations::postgres::instances:
  - host: foo
    port: 5432
    username: postgres
    password: foo_pass
    dbname:
    ssl: False
    tags:
      - Foo DB
      - postgresql
  - host: bar
    port: 5400
    username: postgres
    password: bar_pass
    ssl: False
    tags:
      - Bar DB
      - postgresql

[truthbk]

I think this is mostly great. Thank you so much @rothgar 🙇

It would be awesome if we could update the spec tests to cover the case where we pass an array of instances.

There's also a small stylistic issue on postgres.pp:96

[truthbk]

This line has a minor stylistic issue:

manifests/integrations/postgres.pp:96:only_variable_string:WARNING:string containing only a variable
manifests/integrations/postgres.pp:96:variables_not_enclosed:WARNING:variable not enclosed in {}

The line was originally:

  file { $dst:

which I think is fine, but if you have your reasons for changing that you might have to address it some other way.

[rothgar]

I reverted the file definition. Do you know of an example for testing passing an array of instances? I looked in the mysql tests but didn't see a test for an array so I'm not sure how to do it.

[truthbk]

@rothgar that's OK, I'm working on puppet right now, so I'll add the tests to the suite myself - there are tests for postgres already and as they're passing the output YAML is sane. Thank you very much for your work.