Add network_latency_checks parameter to consul checks (#393)#394
Merged
truthbk merged 1 commit intoDataDog:masterfrom Mar 2, 2018
Merged
Add network_latency_checks parameter to consul checks (#393)#394truthbk merged 1 commit intoDataDog:masterfrom
truthbk merged 1 commit intoDataDog:masterfrom
Conversation
truthbk
approved these changes
Mar 2, 2018
Member
truthbk
left a comment
truthbk
left a comment
There was a problem hiding this comment.
Thank you @Aramack, very much appreciated 🙇
I will be merging this as-is and adding the spec test myself. Next time, if you have the time, it would be awesome if you could add the test for the new feature 😊 In this case it's pretty straight-forward so I'm 100% happy to do it, but sometimes the changes are more convoluted and the author is normally the ideal person to understand what should be tested, edge-cases, etc.
Big thanks once again!
cegeka-jenkins
pushed a commit
to cegeka/puppet-datadog_agent
that referenced
this pull request
Apr 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a network_latency_checks parameter to consul checks, which is supported by the core integration:
https://github.com/DataDog/integrations-core/blob/master/consul/conf.yaml.example#L42
#393