Conversation
remicalixte
force-pushed
the
remicalixte/site-report
branch
from
b8f1b1b to
64a5a41
Compare
truthbk
left a comment
truthbk
left a comment
There was a problem hiding this comment.
This looks pretty good. We do break the interface for datadog_agent::reports currently, let's make it backward compatible.
| # | ||
| class datadog_agent::reports( | ||
| $api_key, | ||
| $datadog_site, |
There was a problem hiding this comment.
This would not be backward compatible if referenced on its own. It's fine in the context of init.pp, but if someone has already written a custom manifest using datadog_agent::reports, this would break it. You'll need to add a default (probably an empty string, or the US site).
There was a problem hiding this comment.
Oh I see, I didn't know it was a public interface
There was a problem hiding this comment.
This is a weird edge case that might not affect anyone, but it's not hard to fix on our side, so let's better be safe than sorry. 🙇
There was a problem hiding this comment.
Should be fixed now
remicalixte
force-pushed
the
remicalixte/site-report
branch
6 times, most recently
from
4ef5507 to
6044e30
Compare
remicalixte
force-pushed
the
remicalixte/site-report
branch
from
6044e30 to
fa05e3e
Compare
* Write api_url in the report config * Use api_url to choose datadog host * Update spec tests * Add a default value for datadog_site
2 participants
PR to apply on top of #464