Conversation
gbbr
reviewed
Jan 1, 2019
LotharSee
reviewed
Jan 3, 2019
LotharSee
reviewed
Jan 3, 2019
gbbr
reviewed
Jan 3, 2019
gbbr
approved these changes
Jan 7, 2019
gbbr
left a comment
gbbr
left a comment
There was a problem hiding this comment.
It looks good to me, but given that I have no experience with Ruby or Puppet, it'd be nice if we could try it out and make sure it's working before merging. Also, CI is failing.
truthbk
reviewed
Jan 7, 2019
truthbk
suggested changes
Jan 18, 2019
| apm_enabled: <%= @apm_enabled %> | ||
|
|
||
| # Enable and the trace search & analytics by adding a list of entered APM events. | ||
| <% if ! @apm_analyzed_spans.nil? -%> |
Member
There was a problem hiding this comment.
I think that given the way this has been defined to use types we can probably just do:
<% if @apm_analyzed_spans -%>
truthbk
force-pushed
the
edwin/apm-trace-search
branch
from
7759a50 to
b03b8a3
Compare
Member
|
Issues addressed:
Merging. |
cegeka-jenkins
pushed a commit
to cegeka/puppet-datadog_agent
that referenced
this pull request
Apr 6, 2020
* Added the ability to apm events for trace search * [apm] adding apm_analyzed_spans for A6 * [apm] adding support for APM analyze spans in A5 + changing argument to hash * [readme] docs + broken table + init description
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrected PR origin now submitting again.
Missing Spec test code, would like some help with that if possible. I have added and updated the manifest, param and init.pp files with the ability to automate the trace search & analytics configuration in the datadog.yaml file.