pass in password via hiera#514
Merged
truthbk merged 2 commits intoDataDog:masterfrom May 4, 2019
cabrinha:patch-1
Merged
Conversation
We should be able to use this class with `include datadog_agent::integrations::postgres`, but without specifying a password, this fails: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Function Call, Class[Datadog_agent::Integrations::Postgres]: expects a value for parameter 'password'
Member
|
Hey @cabrinha! You're absolutely right, we've got a few places that don't really play well with hiera. Haven't forgetten about this - just want to make sure I give it a test run before merging. This, or a variation on top of this, will be shipping with the upcoming release. Thanks! |
truthbk
approved these changes
May 4, 2019
Member
truthbk
left a comment
truthbk
left a comment
There was a problem hiding this comment.
Tested it! Looks good 👌
Although this could potentially generate an incomplete check configuration if the user specifies no password and no instances - thought that would be on the user - given the presence of the instances parameter, all options should either have defaults or be optional to play well with hiera which is exactly what @cabrinha is doing here. Thank you and kudos!
cegeka-jenkins
pushed a commit
to cegeka/puppet-datadog_agent
that referenced
this pull request
Apr 6, 2020
* pass in password via hiera We should be able to use this class with `include datadog_agent::integrations::postgres`, but without specifying a password, this fails: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Function Call, Class[Datadog_agent::Integrations::Postgres]: expects a value for parameter 'password' * it should compile with default params
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should be able to use this class with
include datadog_agent::integrations::postgres, but without specifying a password, this fails:Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Function Call, Class[Datadog_agent::Integrations::Postgres]: expects a value for parameter 'password'