Conversation
KSerrania
reviewed
Nov 2, 2020
The removed section was irrelevant since if keys are not available RPM will automatically import them.
Member
Author
|
Mind taking a second look @KSerrania? |
KSerrania
approved these changes
Nov 6, 2020
cegeka-jenkins
pushed a commit
to cegeka/puppet-datadog_agent
that referenced
this pull request
Feb 5, 2026
* Trust new RPM key * Trust new APT key * Handle keys importing through the gpgkey section The removed section was irrelevant since if keys are not available RPM will automatically import them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Describe your test plan
bundle exec rake testManual tests
Apply the module with the manifests below, it should install the Agent if using this branch's module and fail if using master.
Apply a module with no options, it should install correctly.
Ubuntu
Redhat