Allow creating system_probe.yaml on Windows#685
Closed
albertvaka wants to merge 6 commits intomasterfrom
Closed
Conversation
And add a helper option $system_probe_enable that will both create the file (with the default values) and tell the Windows installer to install the NPM component.
The default arguments aren't enough to enable NPM on Windows
Contributor
Author
|
Superseded by #688 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allow creating
system_probe.yamlon Windows and add the missingnetwork_config.enabledoption.The separate
$windows_npm_installoption is still needed since the class that installs the Agent and the class that configure the system-probe are separate.Motivation
Windows NPM launch.