Skip to content

Support AlmaLinux and Rocky Linux with Puppet >= 7.12.0#726

Merged
bkabrda merged 2 commits intomainfrom
slavek.kabrda/almalinux-rocky
Feb 11, 2022
Merged

Support AlmaLinux and Rocky Linux with Puppet >= 7.12.0#726
bkabrda merged 2 commits intomainfrom
slavek.kabrda/almalinux-rocky

Conversation

@bkabrda
Copy link
Copy Markdown

@bkabrda bkabrda commented Feb 11, 2022

What does this PR do?

Adds support for AlmaLinux and Rocky Linux with Puppet >= 7.12.0.

Motivation

Additional Notes

Describe your test plan

@bkabrda bkabrda requested a review from a team as a code owner February 11, 2022 12:38
@bkabrda bkabrda changed the title Support AlmaLinux and Rocky Linux with Chef >= 7.12.0 Support AlmaLinux and Rocky Linux with Puppet >= 7.12.0 Feb 11, 2022
@bkabrda bkabrda force-pushed the slavek.kabrda/almalinux-rocky branch from 56a463c to 890fd71 Compare February 11, 2022 12:41
Comment thread spec/spec_helper.rb
PERMISSIONS_PROTECTED_FILE = '0600'.freeze
end

def min_puppet_version(version)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nitpicky, but is_puppet_version_greater_than might be more clear? Feel free to ignore if you like the current name better.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong opinion, but I probably prefer the shorter variant, so I'll keep it as-is.

@bkabrda bkabrda merged commit 0d3fedc into main Feb 11, 2022
@bkabrda bkabrda deleted the slavek.kabrda/almalinux-rocky branch February 11, 2022 13:18
cegeka-jenkins pushed a commit to cegeka/puppet-datadog_agent that referenced this pull request Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants