Skip to content

Allow more recent versions of dependencies#728

Merged
mx-psi merged 2 commits intoDataDog:mainfrom
mindhivenz:dependency-ranges
Apr 6, 2022
Merged

Allow more recent versions of dependencies#728
mx-psi merged 2 commits intoDataDog:mainfrom
mindhivenz:dependency-ranges

Conversation

@damonmaria
Copy link
Copy Markdown
Contributor

What does this PR do?

Allow latest versions of: stdlib, concat, apt

Motivation

This module is blocking us from using the most recent versions of these.

Describe your test plan

Assuming low chance of impact. CI tests will pick up any issues.

Allow latest versions of: stdlib, concat, apt
@damonmaria damonmaria requested a review from a team as a code owner April 3, 2022 23:43
@damonmaria
Copy link
Copy Markdown
Contributor Author

Note that the latest versions of these 3 modules all require at least Puppet 6.

@mx-psi
Copy link
Copy Markdown
Member

mx-psi commented Apr 4, 2022

👋 looks like our tests are in bad shape, I opened #729 to fix (most of) them. Please stay put until we merge this (or cherry-pick the commit if you prefer that :) )

@mx-psi mx-psi mentioned this pull request Apr 4, 2022
@damonmaria
Copy link
Copy Markdown
Contributor Author

@mx-psi Thanks. As per my note above, depending on how the Puppet version requirement of these dependencies are enforced the tests on Puppet < 6.1 may fail.

@mx-psi
Copy link
Copy Markdown
Member

mx-psi commented Apr 5, 2022

It should be safe to rebase now, we have some flaky tests but otherwise everything should pass eventually

@mx-psi Thanks. As per my note above, depending on how the Puppet version requirement of these dependencies are enforced the tests on Puppet < 6.1 may fail.

We need to keep support for Puppet 4 and Puppet 5 for now, since we have users using these versions, even if they are EOL. I think this change will be fine for tests given that the range we already have contains versions incompatible with Puppet 4 or Puppet 5 in some cases but, in any case, we will test installation once tests pass to double check.

@mx-psi mx-psi merged commit b93d225 into DataDog:main Apr 6, 2022
cegeka-jenkins pushed a commit to cegeka/puppet-datadog_agent that referenced this pull request Feb 5, 2026
Allow latest versions of: stdlib, concat, apt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants