feat: fix cdk code for log group management

[jeastham1993]

What does this PR do?

Motivation

Testing Guidelines

Additional Notes

Types of Changes

• Bug fix
• New feature
• Breaking change
• Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

• This PR's description is comprehensive
• This PR contains breaking changes that are documented in the description
• This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
• This PR impacts documentation, and it has been updated (or a ticket has been logged)
• This PR's changes are covered by the automated tests
• This PR collects user input/sensitive content into Datadog

[claude]

Claude finished @jeastham1993's task —— View job

---

PR Review Analysis ✅

I've analyzed the PR and can now provide comprehensive feedback on the log group management fix.

Todo List:

• Read the modified file to understand the changes
• Analyze the 3-line deletion for impact
• Review for code quality and best practices
• Check for potential bugs or issues
• Assess performance considerations
• Review security concerns
• Evaluate test coverage impact
• Provide comprehensive feedback

Review Findings

✅ Code Quality & Best Practices

The code follows good CDK/TypeScript practices:

• Proper use of AWS CDK constructs and patterns
• Consistent naming conventions
• Well-structured class with logical separation of concerns
• Appropriate imports and dependency management

🔍 Key Issue Identified: Inconsistent Log Group Management

The PR title mentions "log group management" and I found the critical difference:

• ProductCreated function (lines 88-89): Missing log group removal policy
• ProductUpdated function (line 170): ✅ Has handleProductUpdatedFunction.logGroup.applyRemovalPolicy(RemovalPolicy.DESTROY);

This inconsistency means:

• ProductCreated function log groups will persist after stack deletion (potential cost/cleanup issue)
• ProductUpdated function log groups will be properly cleaned up

🐛 Potential Issues

1. Resource Cleanup Inconsistency: The missing RemovalPolicy.DESTROY on the ProductCreated function's log group could lead to orphaned CloudWatch log groups
2. Cost Impact: Retained log groups continue to incur storage costs even after infrastructure is deleted
3. Environment Pollution: In ephemeral environments, this could accumulate many unused log groups

🔧 Recommended Fix

Add the missing log group removal policy to the ProductCreated function:

// After line 89, add:
handleProductCreatedFunction.logGroup.applyRemovalPolicy(RemovalPolicy.DESTROY);

🚨 Security Considerations

• No security issues identified
• Proper IAM permissions are granted through the service props
• Environment variables follow best practices

⚡ Performance Considerations

• Appropriate memory size (512MB) and timeout (29s) for both functions
• Good use of SQS batch failure reporting
• Efficient bundling configuration with esbuild

🧪 Test Coverage Impact

• No test files were modified in this PR
• Consider adding tests to verify log group removal policies are correctly applied
• Integration tests should validate proper cleanup behavior

📦 Additional Observations

• Both functions use identical configurations except for the log group policy
• The code duplication between the two build methods could be refactored into a helper method
• Import of Effect and PolicyStatement from IAM is unused and could be removed

Overall Assessment

Good infrastructure code with a critical inconsistency in log group management that should be addressed. The missing removal policy is exactly the type of issue the PR title suggests was being fixed.

---

[Copilot]

Pull Request Overview

This PR removes the explicit log group removal policy configuration for a Lambda function in the pricing service CDK code. The change eliminates the manual setting of RemovalPolicy.DESTROY on the function's log group.

• Removes explicit log group removal policy configuration

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

Removing the explicit RemovalPolicy.DESTROY configuration for the log group may cause log groups to persist after stack deletion, potentially leading to resource accumulation and unexpected costs. Consider documenting the intended log retention behavior or implementing a consistent log group management strategy across the service.

Suggested change

	// Ensure the log group is deleted when the stack is destroyed to prevent resource accumulation.
	handleProductCreatedFunction.logGroup.applyRemovalPolicy(RemovalPolicy.DESTROY);