Skip to content

feat: fix cdk code for log group management #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeastham1993 merged 1 commit into from
Sep 10, 2025
+0 −3
Merged

feat: fix cdk code for log group management #474

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/pricing-service/lib/pricing-api/pricingEventHandlers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,6 @@ export class PricingEventHandlers extends Construct {
},
}
);
handleProductCreatedFunction.logGroup.applyRemovalPolicy(
RemovalPolicy.DESTROY
);

Copy link

Copilot AI Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the explicit RemovalPolicy.DESTROY configuration for the log group may cause log groups to persist after stack deletion, potentially leading to resource accumulation and unexpected costs. Consider documenting the intended log retention behavior or implementing a consistent log group management strategy across the service.

Suggested change
// Ensure the log group is deleted when the stack is destroyed to prevent resource accumulation.
handleProductCreatedFunction.logGroup.applyRemovalPolicy(RemovalPolicy.DESTROY);

Copilot uses AI. Check for mistakes.
props.serviceProps
.getPublisherBus()
Expand Down
⚡