Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0e8cd0d0c8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| _, ok := tracer.SetDataStreamsCheckpointWithParams(ctx, options.CheckpointParams{ | ||
| ServiceOverride: "productservice-publiceventpublisher", | ||
| }, "direction:out", "type:eventbridge", "topic:"+cloudEvent.Type, "manual_checkpoint:true") | ||
| }, "direction:out", "type:sns", "topic:"+cloudEvent.Type, "manual_checkpoint:true") |
There was a problem hiding this comment.
These publishers send events through eventbridge.PutEvents and also tag spans with messaging.system = aws_eventbridge, but the checkpoint transport was changed to type:sns; this misclassifies the stream in Datadog Data Streams and can merge EventBridge traffic into SNS pathways, degrading the accuracy of cross-service flow metrics for product public events. Use type:eventbridge for these checkpoint tags (as in the previous implementation).
Useful? React with 👍 / 👎.
1 participant
What does this PR do?
Motivation
Testing Guidelines
Additional Notes
Types of Changes
Check all that apply