Uncommited changes from the user's working copy#628
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1531811753
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| npm i | ||
| ./package.sh |
There was a problem hiding this comment.
Use product-search Make targets in deploy-all script
The new product-search block invokes npm i and ./package.sh, but src/product-search-service does not contain a package.json or package.sh, so this path fails on a clean checkout and never prepares the required .build/lambdas artifact before CDK deploy. This makes cdk-deploy-all.sh unable to deploy product-search-service end-to-end, unlike the documented flow in src/product-search-service/Makefile (make install/make cdk-deploy).
Useful? React with 👍 / 👎.
|
|
||
| namespace Orders.Core; | ||
|
|
||
| public class OrderNotConfirmedException : Exception |
There was a problem hiding this comment.
Restore Orders.Core OrderNotConfirmedException class
Removing this file deletes the only Orders.Core.OrderNotConfirmedException type, but src/order-service/src/Orders.Core/Order.cs still throws new OrderNotConfirmedException() in CompleteOrder(). Because Orders.Core.csproj compiles Order.cs and that file does not import Orders.Core.Domain.Exceptions, this change introduces a hard compile-time failure for the order core project.
Useful? React with 👍 / 👎.
What does this PR do?
Motivation
Testing Guidelines
Additional Notes
Types of Changes
Check all that apply