Skip to content

Uncommited changes from the user's working copy#628

Merged
jeastham1993 merged 1 commit intomainfrom
air/codebase-issue-fix-bf35fe4c-f
Mar 12, 2026
Merged

Uncommited changes from the user's working copy#628
jeastham1993 merged 1 commit intomainfrom
air/codebase-issue-fix-bf35fe4c-f

Conversation

@jeastham1993
Copy link
Copy Markdown
Collaborator

What does this PR do?

Motivation

Testing Guidelines

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog

@jeastham1993 jeastham1993 merged commit c228afe into main Mar 12, 2026
9 of 11 checks passed
@jeastham1993 jeastham1993 deleted the air/codebase-issue-fix-bf35fe4c-f branch March 12, 2026 08:08
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1531811753

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +46 to +47
npm i
./package.sh
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Use product-search Make targets in deploy-all script

The new product-search block invokes npm i and ./package.sh, but src/product-search-service does not contain a package.json or package.sh, so this path fails on a clean checkout and never prepares the required .build/lambdas artifact before CDK deploy. This makes cdk-deploy-all.sh unable to deploy product-search-service end-to-end, unlike the documented flow in src/product-search-service/Makefile (make install/make cdk-deploy).

Useful? React with 👍 / 👎.


namespace Orders.Core;

public class OrderNotConfirmedException : Exception
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P0 Badge Restore Orders.Core OrderNotConfirmedException class

Removing this file deletes the only Orders.Core.OrderNotConfirmedException type, but src/order-service/src/Orders.Core/Order.cs still throws new OrderNotConfirmedException() in CompleteOrder(). Because Orders.Core.csproj compiles Order.cs and that file does not import Orders.Core.Domain.Exceptions, this change introduces a hard compile-time failure for the order core project.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant