Skip to content

fix: rethrow error on catch#101

Merged
DavideViolante merged 2 commits into
masterfrom
throw
Mar 20, 2026
Merged

fix: rethrow error on catch#101
DavideViolante merged 2 commits into
masterfrom
throw

Conversation

@DavideViolante

Copy link
Copy Markdown
Owner

throw error was missing on catch, just a console log was added.

Let me know what you think, I slightly changed the test for abort @romant094 because when the request is aborted the promise is rejected.

@DavideViolante DavideViolante self-assigned this Mar 20, 2026
@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 23351658470

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 23351462495: 0.0%
Covered Lines: 36
Relevant Lines: 36

💛 - Coveralls

@romant094

romant094 commented Mar 20, 2026

Copy link
Copy Markdown
Contributor

throw error was missing on catch, just a console log was added.

Let me know what you think, I slightly changed the test for abort @romant094 because when the request is aborted the promise is rejected.

Agree on both points.

PS thanks for your lib.

@DavideViolante DavideViolante merged commit e361f83 into master Mar 20, 2026
3 checks passed
@DavideViolante DavideViolante deleted the throw branch March 20, 2026 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants