File fields conflict with CSV

[ghaydarov]

I use this gem in just one form in my app and I only load its js file in that forms layout and initializer file content on that forms model.

My problem is, I have different layout with some other forms that I do not want to use client side validation, and these forms use carrierwave. Now this gem automatically loaded everywhere even if I don't want to use this everywhere. With the forms that I don't use this gem, I get error with carrierwave, it just fails to save the form and get translation missing errors when i check the source code. Otherwise I just get cant be blank error.

I hope I explained my situation understandably.

Shortly, I want to use this gem with only one form, but it still shows up in all forms regardless of the layout.

Any ideas? Thanks!

[tagliala]

Hi,

From the README

In your FormBuilder you only need to enable validations:

<%= form_for @user, validate: true do |f| %>
  ...

That should be enough to get you going.

So you should simply skip validate: true if you don't want CSV

Hope it helps

Closing here

[ghaydarov]

Thanks for the reply. That should be expected behavior, I know, but it doesn't just disable it for some reason.

[ghaydarov]

I have this in initializer, could this be loading everywhere, regardless of validate true?

ActionView::Base.field_error_proc = proc do |html_tag, instance|
  if html_tag =~ /^<label/
    %(<div class="field_with_errors">#{html_tag}<label for="#{instance.send(:tag_id)}" class="message">#{instance.error_message.first}</label></div>).html_safe
  else
  	 %(<div class="field_with_errors">#{html_tag}</div>).html_safe
  end
end

[tagliala]

The above initalizer is supposed to render errors on the client side when the server side validations fail and it should not affect forms without errors

Also, the suggested field_error_proc should be:

ActionView::Base.field_error_proc = proc do |html_tag, instance|
  if html_tag =~ /^<label/
    %(<div class="field_with_errors">#{html_tag}</div>).html_safe
  else
    %(<div class="field_with_errors">#{html_tag}<label for="#{instance.send(:tag_id)}" class="message">#{instance.error_message.first}</label></div>).html_safe
  end
end

It looks like that yours invertsif and else branches.

[ghaydarov]

It also should not affect forms without validate: true right?
and field_error_proc I have affect the html where errors appear, and that was intended.

[ghaydarov]

Only time this problem goes away is when I remove the gem from gemfile.

[tagliala]

It also should not affect forms without validate: true right?

Nope, the above code affects all forms

[ghaydarov]

Ok I see, so now I have form without validate true, and this form includes carrierwave field, where I upload image. If I have CSV gem, for image upload field I get 'cant be blank' error. If I remove the CSV gem, error disappears and and everything is good. Would this be something about CW or CSV?

[tagliala]

Ok I see, so now I have form without validate true, and this form includes carrierwave field, where I upload image.

validate: true means that you want to add client side validations. If you don't want CSV for that form, you should not add validate: true to the form_for method parameters.

validate: true when CSV is not installed is useless.

Also, you could skip validations on a specific field with validate: false but I'm giving a look with carrierwave installed because I've changed a lot of stuff

[ghaydarov]

The thing is I am NOT (sorry mistyped) using CSV with that form and i don't want to. and I dont have validate: true. I get cant be blank error and no other errors. May be there is a conflict between the gems. Not sure.

[tagliala]

could you please post everything requested here: https://github.com/DavyJonesLocker/client_side_validations/blob/master/CONTRIBUTING.md#submitting-a-new-issue

Thanks

[ghaydarov]

Thank you. For the sake of reproduction, I scaffolded new rails app. I added Post model with image field. Added gems CSV and CW. I get the same error. Please note that I dont want to use CSV in this form/model. I want to disable it for this form. When I want to use it, i can use it without any problems. I can't disable it for this form. Thats the problem. (btw, if it helps, I get them same behavior regardless of turbolink's presence. )

Using client_side_validations 9.0.0
Using rails 5.0.1
Using carrierwave 1.0.0

Code snippet from my model of the validations

class Post < ApplicationRecord
	mount_uploader :image, ImageUploader
	validates :image, presence: true
end

The form code from my template

<%= form_for(post) do |f| %>
  <% if post.errors.any? %>
    <div id="error_explanation">
      <h2><%= pluralize(post.errors.count, "error") %> prohibited this post from being saved:</h2>

      <ul>
      <% post.errors.full_messages.each do |message| %>
        <li><%= message %></li>
      <% end %>
      </ul>
    </div>
  <% end %>

  <div class="field">
    <%= f.label :title %>
    <%= f.text_field :title %>
  </div>

  <div class="field">
    <%= f.label :image %>
    <%= f.file_field :image %>
  </div>

  <div class="actions">
    <%= f.submit %>
  </div>
<% end %>

The resulting HTML along with the script tag Layout file

<!DOCTYPE html>
<html>
  <head>
    <title>Testapp</title>
    <%= csrf_meta_tags %>

    <%= stylesheet_link_tag    'application', media: 'all', 'data-turbolinks-track': 'reload' %>
    <%= javascript_include_tag 'application', 'data-turbolinks-track': 'reload' %>
  </head>

  <body>
    <%= yield %>
  </body>
</html>

My application.js file

//
//= require jquery
//= require jquery_ujs
//= require turbolinks
//= require rails.validations
//= require_tree .

[tagliala]

The resulting HTML along with the script tag Layout file

This is the .html file generated from your .erb template (right click -> view html source)

<%= form_for(post) do |f| %>
  <% if post.errors.any? %>
...

I would expect something like

<form action="" ...>
</form>