Skip to content

preventing undesired stopPropagation on focusout event#675

Merged
tagliala merged 2 commits intoDavyJonesLocker:masterfrom
investtools:master
Oct 8, 2016
Merged

preventing undesired stopPropagation on focusout event#675
tagliala merged 2 commits intoDavyJonesLocker:masterfrom
investtools:master

Conversation

@akelmanson
Copy link
Copy Markdown
Contributor

it happens when isValid() == false

@coveralls
Copy link
Copy Markdown

coveralls commented Oct 6, 2016

Coverage Status

Coverage remained the same at 99.651% when pulling 4f154f7 on investtools:master into f9903b7 on DavyJonesLocker:master.

@tagliala
Copy link
Copy Markdown
Contributor

tagliala commented Oct 6, 2016

Thanks. Could this be an issue also for some other event?

@akelmanson
Copy link
Copy Markdown
Contributor Author

It might be. If you want, I can modify the other events.

@tagliala
Copy link
Copy Markdown
Contributor

tagliala commented Oct 7, 2016

It might be. If you want, I can modify the other events.
Add your review

Yes, please

@akelmanson
Copy link
Copy Markdown
Contributor Author

Done!

@coveralls
Copy link
Copy Markdown

coveralls commented Oct 7, 2016

Coverage Status

Coverage remained the same at 99.651% when pulling 84764b0 on investtools:master into f9903b7 on DavyJonesLocker:master.

@tagliala
Copy link
Copy Markdown
Contributor

tagliala commented Oct 7, 2016

I can squash commits automatically, did you run rake test:js to check that everything is fine?

@akelmanson
Copy link
Copy Markdown
Contributor Author

Tested on chrome and got the same 4 errors I've got with v4.2.6.

@tagliala
Copy link
Copy Markdown
Contributor

tagliala commented Oct 7, 2016

which version/os? everything is fine on chrome 53 / OSX 10.12

@akelmanson
Copy link
Copy Markdown
Contributor Author

test_js

@tagliala tagliala merged commit 77b9a92 into DavyJonesLocker:master Oct 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants