Guard against prototype extended arrays

[davidenglishmusic]

Certain frameworks like Ember extend the array type with additional properties. Although they can be disabled ( https://guides.emberjs.com/release/configuring-ember/disabling-prototype-extensions/ ), it would remove some helpful functionality. In the case, the iteration through the additional properties by the execute validator code can result in undefined being passed as the third argument. The code change guards against that case.

[tagliala]

Thanks!

The PR cannot be merged because, according to codeclimate, it overcomplicates the executeValidators method: https://codeclimate.com/github/DavyJonesLocker/client_side_validations/pull/769

Anyway... we have others for ... in in the source code, do we need to replace them too?

[tagliala]

@davidenglishmusic thanks.

What about other for .. in ?

[davidenglishmusic]

@tagliala thanks for the quick responses here. I am going to test out a few of the others to see if any additional changes are necessary and will post back.

[tagliala]

@davidenglishmusic

If this can cause issues, and some eslint configurations forbid the use of for ... in I'm fine with a JavaScript standard loop with all the variables and stuff

[davidenglishmusic]

The guard clause has resolved the issue I was experiencing and mirrors the approach in the executeValidators method ( https://github.com/DavyJonesLocker/client_side_validations/blob/master/src/main.js#L156 ). It could be worthwhile moving away from the for ... in as you said although it strikes me that it might take a lot of data structure conversion.

[tagliala]

@davidenglishmusic I will proceed to merge and release during the weekend, thanks 👍

[tagliala]

@davidenglishmusic thanks

16.0.2 gem / 0.0.5 npm released

If you have more time to invest on CSV, there are some features I'm looking for help:

1. Idempotent events
2. Run JavaScript tests on CI (Run javascript unit tests on CI #591)
3. Promise-based approach (client_side_validations uses synchronous ajax #226) (Proposal: change to model based validations on client #490)
4. Remove jQuery dependency

Ref: #692