Skip to content

tests: fix flaky tests that fail due to type strictness #3010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prasannavl merged 1 commit into from
Aug 27, 2024
Merged

tests: fix flaky tests that fail due to type strictness #3010

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions test/functional/feature_any_accounts_to_accounts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,12 +122,11 @@ def run_test(self):
self.nodes[0].generate(1)

for token in tokens:
token_bal = minterAccountBalances[token["tokenId"]]
if i == wallet1_accs_count - 1: # last account
amount = minterAccountBalances[token["tokenId"]]
amount = token_bal
else:
amount = random.randint(
0, minterAccountBalances[token["tokenId"]] // 2
)
amount = random.randint(0, int(token_bal // 2))

if amount == 0:
continue
Expand Down
2 changes: 1 addition & 1 deletion test/functional/feature_poolswap_mechanism.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ def poolswap(self, nodes):
self.nodes[0].generate(1)
self.sync_blocks(nodes)

amount = random.randint(1, (self.AMOUNT_TOKEN / 2) // 2)
amount = random.randint(1, int((self.AMOUNT_TOKEN / 2) // 2))
amountsB = {}
reserveA = self.nodes[0].getpoolpair(pool, True)[idPool]["reserveA"]
reserveB = self.nodes[0].getpoolpair(pool, True)[idPool]["reserveB"]
Expand Down
⚡