Skip to content
This repository was archived by the owner on Jul 1, 2024. It is now read-only.

Rename noNulls() -> noNullish()#249

Merged
elibarzilay merged 3 commits intoDefinitelyTyped:masterfrom
jablko:patch-25
Dec 2, 2020
Merged

Rename noNulls() -> noNullish()#249
elibarzilay merged 3 commits intoDefinitelyTyped:masterfrom
jablko:patch-25

Conversation

@jablko
Copy link
Copy Markdown
Contributor

@jablko jablko commented Dec 2, 2020

#235 (comment)

How about noNullish()? NonNullable<Type> is somewhat analogous but "nullable" doesn't describe values. I went with "nullish" like "nullish coalescing", "nullish checks", etc.

Copy link
Copy Markdown
Contributor

@elibarzilay elibarzilay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elibarzilay elibarzilay merged commit 70ce9c8 into DefinitelyTyped:master Dec 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants