This repository was archived by the owner on Jul 1, 2024. It is now read-only.
Put explanations next to lines in question#288
Open
jablko wants to merge 21 commits intoDefinitelyTyped:masterfrom
Open
Put explanations next to lines in question#288jablko wants to merge 21 commits intoDefinitelyTyped:masterfrom
jablko wants to merge 21 commits intoDefinitelyTyped:masterfrom
Conversation
Contributor
|
To reply to your comment from the other thread:
I'm guessing that "minus the actual suggestions" means not suggesting a fixed config--? If so, I specifically want to wait before making this done via a code review comment which sounds more formal. So instead I was thinking of a short parenthesized explanation (you edited |
jablko
force-pushed
the
patch-44
branch
4 times, most recently
from
aeb9fae to
5e370e0
Compare
Co-authored-by: Eli Barzilay <eli@barzilay.org>
elibarzilay
force-pushed
the
master
branch
3 times, most recently
from
1d39a68 to
9e931d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#285 (comment)