This repository was archived by the owner on Jul 1, 2024. It is now read-only.
Combine dependent actions#348
Merged
elibarzilay merged 1 commit intoDefinitelyTyped:masterfrom Feb 1, 2021
Merged
Conversation
jablko
force-pushed
the
patch-80
branch
2 times, most recently
from
9451735 to
2d870a5
Compare
jablko
changed the title
This was referenced Jan 21, 2021
Instead of having independent `targetColumn`, `shouldUpdateProjectColumn`, and `shouldRemoveFromActiveColumns`. Update snapshots.
elibarzilay
approved these changes
Feb 1, 2021
Contributor
elibarzilay
left a comment
elibarzilay
left a comment
There was a problem hiding this comment.
LGTM, except that it slightly bugs me to use REMOVE, so I tweaked it to *REMOVE* instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor detail but it could be more obvious, when we set
targetColumn,shouldUpdateProjectColumnandshouldRemoveFromActiveColumnsindependently, what the result will be. What do you think about combining these three and replacingshouldRemoveFromActiveColumnswith "REMOVE"?Also I replaced "context" with "actions" in
compute-pr-actions.ts, to matchexecute-pr-actions.ts, etc.