Fix for TMOHS1 and CT2MHS01 dropping Wifi AP after 10 min#951
Open
BeigeBox wants to merge 3 commits intoEFForg:mainfrom
Open
Fix for TMOHS1 and CT2MHS01 dropping Wifi AP after 10 min#951BeigeBox wants to merge 3 commits intoEFForg:mainfrom
BeigeBox wants to merge 3 commits intoEFForg:mainfrom
Conversation
338c75c to
59067a7
Compare
Collaborator
|
Do either of those devices not have their own admin UI where this setting can be changed? That's how I deal with it on tplink. |
Contributor
Author
I didn't see one, although admittedly it's been a while since I checked the default interface the thing ships with. My concern is mostly for folks who install this, then don't read a ton of documentation and just think it's broken and dump it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
cargo fmt.You must check one of:
When these two devices don't have any clients on their wifi AP after 10 minutes they shutdown the wifi. This presents an issue since then the user can't access the device without manual intervention. I added a checkbox (near where the colorblind checkbox is) in the config section that will change a config value to prevent the wifi from shutting down if there's no clients. It's off by default, and only shows on those 2 models.
I tested it on both the devices by deploying the change, waiting 10 minutes without connecting and confirmed that this fixes the issue. Based on a review of issues it looks liek this is a potential fix for #466. If the user was on their home wifi rather than the devices wifi and it took 10 minutes they could see what appears to be a device which doesn't have wifi available (and had a failed install due to the timeout issue I'm fixing in another PR).
I DID use Claude to add the quick button on the web GUI, although I've deployed this and exercised the web GUI myself.