Skip to content

Apply review comments#18

Merged
ESadouski merged 4 commits intoESadouski:ecommerce-dashboardfrom
denStrigo:feat/ecommerce_fix_review
Aug 1, 2018
Merged

Apply review comments#18
ESadouski merged 4 commits intoESadouski:ecommerce-dashboardfrom
denStrigo:feat/ecommerce_fix_review

Conversation

@denStrigo
Copy link
Copy Markdown

Please read and mark the following check list before creating a pull request (check one with "x"):

Short description of what this resolves:

@@ -1,9 +1,10 @@
import { Component } from '@angular/core';
import {Component} from '@angular/core';
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add spaces

@@ -19,7 +19,7 @@ export class TrafficRevealCardComponent implements OnDestroy {
private alive = true;

// TODO: move to service
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use service now?

@ESadouski ESadouski merged commit 82e78a7 into ESadouski:ecommerce-dashboard Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants