Skip to content

FAIR RS content#38

Merged
anenadic merged 41 commits intomainfrom
anenadic-fair-rs
Oct 14, 2024
Merged

FAIR RS content#38
anenadic merged 41 commits intomainfrom
anenadic-fair-rs

Conversation

@anenadic
Copy link
Copy Markdown
Collaborator

No description provided.

@anenadic anenadic changed the title Update fair.md FAIR RS content Sep 18, 2024
@anenadic anenadic marked this pull request as draft September 18, 2024 15:00
@anenadic anenadic requested a review from dgarijo September 18, 2024 15:00
@anenadic anenadic marked this pull request as ready for review September 18, 2024 15:15
Comment thread pages/rs_quality/fair.md
Comment thread pages/rs_quality/fair.md Outdated
Comment thread pages/rs_quality/fair.md
@lauportell
Copy link
Copy Markdown
Contributor

I think the page looks great and give a good overview of the FAIR principles for software.
We can let others from other science clusters review it in case they want to add anything, but it a very good starting point. I only suggested some small changes and corrected some typos.

Comment thread pages/rs_quality/fair.md Outdated
@anenadic anenadic requested a review from lauportell October 1, 2024 10:21
@anenadic
Copy link
Copy Markdown
Collaborator Author

anenadic commented Oct 1, 2024

Thank you for the review @lauportell - I'd like to merge this and we can get more people to add their comments later on due to the deadline of getting the content in before the demo. Would have a look again please @lauportell and approve this PR?

@dgarijo
Copy link
Copy Markdown
Contributor

dgarijo commented Oct 1, 2024

I will do a review of this soon. We have to mention https://fair-impact.github.io/RSMD-guidelines/ which are key for metadata and FAIRness.

@anenadic
Copy link
Copy Markdown
Collaborator Author

anenadic commented Oct 1, 2024

I will do a review of this soon. We have to mention https://fair-impact.github.io/RSMD-guidelines/ which are key for metadata and FAIRness.

Sounds good - pls feel free to add more tools.

@dgarijo
Copy link
Copy Markdown
Contributor

dgarijo commented Oct 10, 2024

will do a review today

Comment thread pages/rs_quality/fair.md
Comment thread pages/rs_quality/fair.md

### Findable
- Create a description of your software to make it discoverable by search engines and other search tools
- Place your software in a public software repository (and ideally register it in a [general-purpose or domain-specific software registry][software-registries])
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should recommend firs trying to register your tool in a community registry (domain-specific, such as bio-tools or ASCL), and if such community registry does not exist, then register it in a general purpose one.

Comment thread pages/rs_quality/fair.md
Comment thread pages/rs_quality/fair.md Outdated
Comment thread pages/rs_quality/fair.md Outdated

### Accessible
- Make sure people can freely, legally and easily get a copy your software
- Structure your code using common patterns and use coding conventions to make your code readable and understandable by people (once they obtain a copy of it), i.e. make your code accessible in the *intelligible* sense
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is reusability, not accesibility :(

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We interpret accessible as you can obtain it and also as you can understand and grasp it

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But look at what the principle states. It has nothing to do with licensing issues!
We can't reinterpret the word in another context, in my opinion:
A: Software, and its metadata, is retrievable via standardized protocols

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could have a private license and still be accessible

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed via 88db083.

Comment thread pages/rs_quality/fair.md Outdated
Comment thread pages/rs_quality/fair.md Outdated
| Coding conventions | | x | x | x |
| Software-level documentation (comments and docstrings, explaining functionality) | | x | x | x |
| Project-level documentation (READMEs, explaining functionality/installation/running) | | x | x | x |
| License - code sharing and reuse | | x | | x |
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

License is reusability, not accessibility

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd argue also accessibility - if you cannot legally obtain the software, you cannot reuse it.

Comment thread pages/rs_quality/fair.md Outdated
| Testing - code correctness and reproducibility | | x | | x |
| Coding conventions | | x | x | x |
| Software-level documentation (comments and docstrings, explaining functionality) | | x | x | x |
| Project-level documentation (READMEs, explaining functionality/installation/running) | | x | x | x |
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not accessibility

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd argue it is also about making people understand/grasp the code - hence accessibility in that sense.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed via 88db083.

Comment thread pages/rs_quality/fair.md Outdated
Comment thread pages/rs_quality/fair.md Outdated

| Tools and practices | Findable | Accessible | Interoperable | Reusable |
| ---------------------------------------------------------------------------------------------------- | -------- | ---------- | ------------- | -------- |
| Virtual development environments | | x | | x |
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not accessibility, but +1 R3: software meets domain-specific community standards

@dgarijo
Copy link
Copy Markdown
Contributor

dgarijo commented Oct 10, 2024

@anenadic sorry it took a while. Not sure if you can address all the comments in time. Happy to go forward (maybe fixing the things that are not correct according to FAIR4S?) and add the rest in an issue to be looked at later.

@dgarijo
Copy link
Copy Markdown
Contributor

dgarijo commented Oct 10, 2024

And thanks for taking a stab at this. It is maybe one of the pages that will be more difficult to complete just because there is so much stuff out there.

@anenadic
Copy link
Copy Markdown
Collaborator Author

@dgarijo - thanks for the review. I see the point of your arguments and happy to have a chat to make sure we reach a consensus and can make an initial version we are all happy with. Will get in touch with you separately.

@anenadic
Copy link
Copy Markdown
Collaborator Author

Thanks for the chat earlier today @dgarijo - I believe all identified issues have been addressed via 88db083 and we have the first draft ready. Cheers!

@dgarijo
Copy link
Copy Markdown
Contributor

dgarijo commented Oct 14, 2024

@anenadic the main.yaml files has some conflicts. Can you please resolve them?

@anenadic anenadic merged commit df0656d into main Oct 14, 2024
@anenadic anenadic deleted the anenadic-fair-rs branch October 14, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants