Adds a fix for nested properties on association fields#7585
Adds a fix for nested properties on association fields#7585KDederichs wants to merge 1 commit intoEasyCorp:5.xfrom
Conversation
Only merge AFTER EasyCorp#7500 is merged
| ->arg(2, service('request_stack')) | ||
| ->arg(3, service(ControllerFactory::class)) | ||
| ->arg(4, new Reference(FieldFactory::class)) | ||
| ->arg(5, service(EntityRepository::class)) |
There was a problem hiding this comment.
Hi @KDederichs,
Instead of adding this dependency to many field configurators (I saw you also created a similar PR for the CollectionConfigurator, and I also did the same with EntityConfigurator in my PR), maybe we can move it to the CommonPreConfigurator, so we resolve the field association once for all field configurators and avoid code duplication?
Also, this may no longer be needed:
EasyAdminBundle/src/Field/Configurator/CommonPreConfigurator.php
Lines 79 to 87 in aaf20db
There was a problem hiding this comment.
Might be a better solution to solidify it in one place when possible yeah.
Tbh I just needed it in that moment in my backend so I fixed the issue where it popped up as I implemented the things I needed (and applied them to production via Patch files).
If you want you can extend your PR with a general solution, since both of mine are dependent on your PR anyways.
Only merge AFTER #7500 is merged