Skip to content

add spark internal book#6434

Merged
eshellman merged 10 commits intoEbookFoundation:masterfrom
aorjoa:add-spark-internal
Oct 28, 2021
Merged

add spark internal book#6434
eshellman merged 10 commits intoEbookFoundation:masterfrom
aorjoa:add-spark-internal

Conversation

@aorjoa
Copy link
Copy Markdown
Contributor

@aorjoa aorjoa commented Oct 25, 2021 •
edited
Loading

What does this PR do?

Add resource

For resources

Description

Apache Spark internal stuff book

Why is this valuable (or not)?

For an in-depth understanding of Apache Spark

How do we know it's really free?

it's public access with permission

For book lists, is it a book? For course lists, is it a course? etc.

Spark Internals

Checklist:

  • Read our contributing guidelines
  • Search for duplicates.
  • Include author(s) and platform where appropriate.
  • Put lists in alphabetical order, correct spacing.
  • Add needed indications (PDF, access notes, under construction)

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

@davorpa
Copy link
Copy Markdown
Member

davorpa commented Oct 25, 2021

TIP ✍️: It's a good practice to fill Pull Request fields. It helps a bit we can understand your contribution better 🤗. and then, increase maintainers productivity 🚀

@davorpa
Copy link
Copy Markdown
Member

davorpa commented Oct 25, 2021 •
edited
Loading

Why use slideshare with captures about your fork and not the upstream github pages site?

Fork: https://github.com/Aorjoa/SparkInternals
Repo: https://github.com/JerryLead/SparkInternals

@davorpa davorpa added the question Needs clarification by involved users / reviewers label Oct 25, 2021
@aorjoa
Copy link
Copy Markdown
Contributor Author

aorjoa commented Oct 26, 2021

Thanks, @davorpa. I will change to the repository.

davorpa
davorpa requested changes Oct 26, 2021
View reviewed changes
Comment thread books/free-programming-books-th.md Outdated
@aorjoa @davorpa
Update books/free-programming-books-th.md
f5687c9 
Co-authored-by: David Ordás <3125580+davorpa@users.noreply.github.com>
@davorpa davorpa removed the question Needs clarification by involved users / reviewers label Oct 26, 2021
@davorpa davorpa self-requested a review October 26, 2021 10:57
davorpa
davorpa reviewed Oct 26, 2021
View reviewed changes
Comment thread books/free-programming-books-th.md Outdated
@davorpa davorpa added the waiting for changes PR has been reviewed and changes/suggestions requested label Oct 26, 2021
aorjoa
aorjoa commented Oct 26, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@aorjoa aorjoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread books/free-programming-books-th.md Outdated
@eshellman
Copy link
Copy Markdown
Collaborator

eshellman commented Oct 26, 2021

I couldn't find any thai language resources

@eshellman eshellman added question Needs clarification by involved users / reviewers and removed waiting for changes PR has been reviewed and changes/suggestions requested labels Oct 26, 2021
@davorpa
Copy link
Copy Markdown
Member

davorpa commented Oct 26, 2021

I couldn't find any thai language resources

Taking a look at README.md it's here 😉: https://github.com/JerryLead/SparkInternals/tree/HEAD/markdown/thai

davorpa
davorpa reviewed Oct 26, 2021
View reviewed changes
Comment thread books/free-programming-books-th.md Outdated
davorpa
davorpa reviewed Oct 27, 2021
View reviewed changes
Comment thread books/free-programming-books-th.md Outdated
aorjoa and others added 3 commits October 27, 2021 09:21
@aorjoa @davorpa
change TOC title to group of content
adec79d 
Co-authored-by: David Ordás <3125580+davorpa@users.noreply.github.com>
@aorjoa
trigger linter
5e2ee87
@aorjoa
remove typo
f791c5a
@aorjoa
Copy link
Copy Markdown
Contributor Author

aorjoa commented Oct 27, 2021

what's wrong with lint?

@davorpa
Copy link
Copy Markdown
Member

davorpa commented Oct 27, 2021

what's wrong with lint?

Check logs...

Bad news: the section and its TOC entry have to be transferred at the beginning, before Go. Out of suggestions scope.

@davorpa davorpa added the waiting for changes PR has been reviewed and changes/suggestions requested label Oct 27, 2021
davorpa
davorpa requested changes Oct 27, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@davorpa davorpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

free-programming-books/books/free-programming-books-th.md

Lines 30 to 34 in 4c75702

### Apache Spark
* [Spark Internals](https://github.com/JerryLead/SparkInternals) - Lijie Xu, Bhuridech Sudsee

Section goes before Go too

@davorpa davorpa removed the waiting for changes PR has been reviewed and changes/suggestions requested label Oct 27, 2021
@davorpa davorpa added the 🚀 ready to merge LGTM. Waiting for final approval label Oct 27, 2021
@eshellman eshellman mentioned this pull request Oct 27, 2021
Open
@eshellman
Copy link
Copy Markdown
Collaborator

eshellman commented Oct 27, 2021

I notice that @aorjoa is the translator for this book. So... JerryLead/SparkInternals#76

@eshellman eshellman removed the 🚀 ready to merge LGTM. Waiting for final approval label Oct 27, 2021
davorpa
davorpa reviewed Oct 27, 2021
View reviewed changes
Comment thread books/free-programming-books-th.md Outdated
@davorpa davorpa added waiting for changes PR has been reviewed and changes/suggestions requested and removed question Needs clarification by involved users / reviewers labels Oct 28, 2021
@aorjoa @davorpa
more specific document to Thai version
37ab4ba 
Co-authored-by: David Ordás <3125580+davorpa@users.noreply.github.com>
@davorpa davorpa added 🚀 ready to merge LGTM. Waiting for final approval and removed waiting for changes PR has been reviewed and changes/suggestions requested labels Oct 28, 2021
@eshellman
Copy link
Copy Markdown
Collaborator

eshellman commented Oct 28, 2021

Thanks, and welcome to free-programming-books!

@eshellman eshellman merged commit bedd416 into EbookFoundation:master Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eshellman eshellman eshellman left review comments

@davorpa davorpa davorpa approved these changes

Assignees

@aorjoa aorjoa

Labels

🚀 ready to merge LGTM. Waiting for final approval

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aorjoa @davorpa @eshellman
⚡