The Prettier linter, main.yml GitHub Actions Flow and Pull Request UI

[stemount]

• There is a slight issue with JSONLinting #173 where the GitHub prettier-lint-check.yml action happens on push and pull_request update whereas main.yml runs on push.

I've separated this issue as I wanted more of the community to get involved in understanding GitHub Actions and I'd love some feedback on what you think.

As in CircleCI, Travis and similar, you will find most CI/CD pipelines to be somewhat procedural, with the exceptions of well crafted "parallelism" where all parallel jobs must have a valid exit code or the entire job fails. You can also specify otherwise, e.g. parallelise all the things but let the developer know which tests did fail. (Think more than one language/stack in a mono-repo.)

This does open a problem as even if it does find a Prettier fault, it will ❌ that action, however that has ran after it has gone ahead and ran main.yml.

This may just be me, but this UI suggests quite the opposite of what is happening here:

Suggestion:

Suggestion is to:

• collaborate on how to order these actions, check if these on: [push] and on: [push, request] is correct
• work on how we ensure that Prettier failing is really clear in the GitHub UI.
  • Because the main.yml awesome gihub profiles generator will run in parallel of the prettier-lint-check, even if the JSON is not exactly "pretty", it will look like it's got the all clear from the GitHub action/
  • This separated file may not be best. as they run in parallel.

[github-actions]

Stale issue message

[schmelto]

See also #211

[github-actions]

Stale issue message

[gptkrsh]

Can I try working on this?

[naomi-lgbt]

I think this is no longer an issue with #881 merged.

[gptkrsh]

Can someone close this in that case? 😓