Skip to content
This repository was archived by the owner on Jul 28, 2024. It is now read-only.

Update data.json#318

Merged
AllanRegush merged 2 commits intoEddieHubCommunity:mainfrom
roaldnefs:main
Feb 6, 2021
Merged

Update data.json#318
AllanRegush merged 2 commits intoEddieHubCommunity:mainfrom
roaldnefs:main

Conversation

@roaldnefs
Copy link
Copy Markdown
Contributor

Updated data.json to add my personal GitHub profile readme (#315).

Copy link
Copy Markdown
Contributor

@schmelto schmelto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@AllanRegush AllanRegush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good 👍 Thank you 😄

@AllanRegush
Copy link
Copy Markdown
Contributor

It looks like there is a conflict. Could you resolve this? If you need any help let me know 🤓

@AllanRegush AllanRegush linked an issue Feb 6, 2021 that may be closed by this pull request
@AllanRegush
Copy link
Copy Markdown
Contributor

Thank you for reviewing @schmelto

@roaldnefs
Copy link
Copy Markdown
Contributor Author

@AllanRegush, I've resolved the conflict but made sure to not add me as the last profile in the data.json file, otherwise we would keep running into conflicts while other PRs are merged first.

Copy link
Copy Markdown
Contributor

@AllanRegush AllanRegush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good 👍

@AllanRegush AllanRegush merged commit a79eb20 into EddieHubCommunity:main Feb 6, 2021
@eddiejaoude
Copy link
Copy Markdown
Member

Great work, thanks all 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Roald Nefs

4 participants