Skip to content
This repository was archived by the owner on Jul 28, 2024. It is now read-only.

add rudrabarad#441

Merged
schmelto merged 3 commits intoEddieHubCommunity:mainfrom
rudrabarad:main
May 1, 2021
Merged

add rudrabarad#441
schmelto merged 3 commits intoEddieHubCommunity:mainfrom
rudrabarad:main

Conversation

@rudrabarad
Copy link
Copy Markdown
Contributor

resolve #440

Copy link
Copy Markdown
Contributor

@AllanRegush AllanRegush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good 👍 Thank you 😄

@AllanRegush
Copy link
Copy Markdown
Contributor

Thanks for reviewing @schmelto

@AllanRegush
Copy link
Copy Markdown
Contributor

@rudrabarad Looks like there is a merge conflict. Could you resolve this? If you need any help let us know 🤓

@rudrabarad
Copy link
Copy Markdown
Contributor Author

@rudrabarad Looks like there is a merge conflict. Could you resolve this? If you need any help let us know

I've successfully resolved the conflict @AllanRegush

Copy link
Copy Markdown
Contributor

@schmelto schmelto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe a small improvement

data.json Outdated
"issueNumber": 436
},
{

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

data.json Outdated
"githubUsername": "Rishabhrathore055",
"imageUrl": "https://user-images.githubusercontent.com/77366500/115426452-234e8880-a21e-11eb-9e2d-c508acdb921f.jpg",
"issueNumber": 445

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@rudrabarad
Copy link
Copy Markdown
Contributor Author

Can you check now? @AllanRegush 😅

@schmelto schmelto merged commit 4f09712 into EddieHubCommunity:main May 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rudra Barad

3 participants