Skip to content
This repository was archived by the owner on Jul 28, 2024. It is now read-only.

add Ayushparikh-code#521

Merged
schmelto merged 3 commits intoEddieHubCommunity:mainfrom
Ayushparikh-code:main
May 19, 2021
Merged

add Ayushparikh-code#521
schmelto merged 3 commits intoEddieHubCommunity:mainfrom
Ayushparikh-code:main

Conversation

@Ayushparikh-code
Copy link
Copy Markdown
Member

@Ayushparikh-code Ayushparikh-code commented May 19, 2021

resolve #519

starlightknown
starlightknown approved these changes May 19, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@starlightknown starlightknown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ayushparikh-code
Copy link
Copy Markdown
Member Author

Ayushparikh-code commented May 19, 2021

LGTM

LGTM means ?

@starlightknown
Copy link
Copy Markdown
Member

starlightknown commented May 19, 2021

Looks good to me

@Ayushparikh-code
Copy link
Copy Markdown
Member Author

Ayushparikh-code commented May 19, 2021 •
edited
Loading

Looks good to me

Thanks for helping me out

@starlightknown
Copy link
Copy Markdown
Member

starlightknown commented May 19, 2021

Anytime :)

schmelto
schmelto approved these changes May 19, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@schmelto schmelto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@schmelto schmelto merged commit 85213fa into EddieHubCommunity:main May 19, 2021
@schmelto
Copy link
Copy Markdown
Contributor

schmelto commented May 19, 2021 •
edited
Loading

Thanks @starlightknown for reviewing and collaboration 🚀

@schmelto schmelto mentioned this pull request May 19, 2021
Closed
@starlightknown
Copy link
Copy Markdown
Member

starlightknown commented May 19, 2021

Screenshot_2021-05-19-20-31-25-598_com android chrome
By clicking on that smiley icon you can add emojis

@Ayushparikh-code
Copy link
Copy Markdown
Member Author

Ayushparikh-code commented May 19, 2021 •
edited
Loading

Screenshot_2021-05-19-20-31-25-598_com android chrome
By clicking on that smiley icon you can add emojis

oh got it thanks

@schmelto
Copy link
Copy Markdown
Contributor

schmelto commented May 19, 2021 •
edited
Loading

image
you can also take a look at the top right corner

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@schmelto schmelto schmelto approved these changes

@starlightknown starlightknown starlightknown approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Ayush Parikh

3 participants

@Ayushparikh-code @starlightknown @schmelto
⚡