Skip to content
This repository was archived by the owner on Jul 28, 2024. It is now read-only.

add skjha1 #543

Merged
schmelto merged 2 commits into from
Jun 2, 2021
Merged

add skjha1 #543

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce7223f
Update data.json
skjha1 Jun 2, 2021
be863dc
Update data.json
skjha1 Jun 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -965,4 +965,10 @@
"imageUrl": "https://user-images.githubusercontent.com/49101362/120364787-7c501880-c2c2-11eb-8f18-0f0ef10c4439.png",
"issueNumber": 539
}
Copy link
Copy Markdown
Contributor

@schmelto schmelto Jun 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
},

there is a comma missing

Copy link
Copy Markdown
Member Author

@skjha1 skjha1 Jun 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry! changed now #545

Copy link
Copy Markdown
Member

@starlightknown starlightknown Jun 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it doesn't contain your entry

Copy link
Copy Markdown
Contributor

@schmelto schmelto Jun 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem. For this issue you don't have to make a new Pull Request. I think it also wouldn't working this way 🤔 .

You can adjust the issues in this pull request in this branch https://github.com/skjha1/awesome-github-profiles/tree/patch-1 if you create another branch this will open a new PR which is not connected to this one.

So what to do now :)

You can add the missing comma in the patch-1 branch of your fork or you can simply commit the suggestion here in the PR by hitting the "Commit Suggestion" Button above.
image

Both ways will add a commit into this Pull Request and then I think we are free to go to merge it :)

If there are some more questions please let us know 🚀

Copy link
Copy Markdown
Contributor

@schmelto schmelto Jun 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it doesn't contain your entry

Fast as always :D

{
"name": "Shivendra K Jha",
"githubUsername": "skjha1",
"imageUrl": "https://user-images.githubusercontent.com/47923680/120433441-d7ecd580-c398-11eb-9c5c-fe8cd356e4d2.jpg",
"issueNumber": 542
}
]
⚡