Action will break on branches with '/'

[AllanRegush]

await readmeBox.updateSection(table, {
    owner: process.env.GITHUB_REPOSITORY.split('/')[0],
    repo: process.env.GITHUB_REPOSITORY.split('/')[1],
    branch: process.env.GITHUB_REF.split('/')[2], // this will break if branch contains '/'
    token: githubToken,
    section: 'data-section',
});

[github-actions]

It's great having you contribute to this project

Feel free to raise an Issue! Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

[eddiejaoude]

Ah yes good point, any ideas on a solution?

[AllanRegush]

Here is an option to fix this.

    const start = githubRef.indexOf('refs/heads/');
    const branch = githubRef.substring(start, githubRef.length);
    try {
        await readmeBox.updateSection(result ,{
            owner: githubRepository.split('/')[0],
            repo: githubRepository.split('/')[1],
            branch,
            token: githubToken,
            section: 'links',
    });

[alrifay]

We can use regular expression to get branch/tag name.

function getBranch(ref) {
    if (typeof ref != 'string') return;
    const result = ref.match(/^refs\/(heads|tags|remotes\/[^/]*)\/(.*)$/);
    if (!result) return;
    return result[2];
}

getBranch();                                         // output: undefined
getBranch('some random string');                     // output: undefined
getBranch('refs/heads/develop');                     // output: develop
getBranch('refs/heads/feature/add-dotenv');          // output: feature/add-dotenv
getBranch('refs/remotes/origin/develop');            // output: develop
getBranch('refs/remotes/origin/feature/add-dotenv'); // output: feature/add-dotenv
getBranch('refs/remotes/upstream/develop');          // output: develop
getBranch('refs/tags/v1.0.0');                       // output: v1.0.0

References

• difference between "branchname" and "refs/heads/branchname"
• git show-ref

[eddiejaoude]

Oh nice idea, regex 👍

[github-actions]

Stale issue message

[eddiejaoude]

Noooo stalebot 😱

[naomi-lgbt]

This issue is still impacting PRs: EddieHubCommunity/awesome-github-profiles#881

[eddiejaoude]

Oh I was just trying figure out why that PR was failing, thank you 👍