fix: preserve imported token migrations

[samholmes]

Imported token migrations were losing their parent wallet context between wallet creation and the migration flow, which made token migrations disappear or crash before users could review them.

Track the created wallet ids during import completion and carry the parent wallet metadata into the migration payload so imported tokens reach the migration scenes as first-class assets.

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

• Yes
• No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

• Tested on iOS device
• Tested on Android device
• Tested on small-screen device (iPod Touch)
• Tested on large-screen device (tablet)

---

Note

High Risk
Touches wallet migration and private-key sweep transaction construction, including fee calculation and token enable/disable behavior, so regressions could impact fund transfers and user balances. Adds a new multi-asset makeMaxSpend path that needs plugin compatibility and careful error handling.

Overview
Fixes imported-wallet migration so selected tokens stay attached to their newly-created parent wallet by building the migration payload from only successfully created wallets and propagating the correct createWalletId/wallet metadata into token items.

Updates migration and sweep fee/transfer flows to optionally use a plugin-provided multi-asset otherMethods.makeMaxSpend, marking token fees as "Included" when bundled into a single transaction, and adjusts sweep completion logic to handle the single multi-asset transaction case.

Adds the string_included locale string and updates ESLint overrides to stop listing some scenes that are no longer exempted.

^{Reviewed by Cursor Bugbot for commit b4ec9dc. Bugbot is set up for automated code reviews on this repo. Configure here.}

---

• To see the specific tasks where the Asana app for GitHub is being used, see below:
  • https://app.asana.com/0/0/1213831335736726

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Autofix Details

Bugbot Autofix prepared a fix for the issue found in the latest run.

• ✅ Fixed: PluginId-keyed map loses wallets sharing same plugin
  • Changed createdWalletIdsByPluginId to key by unique item.key instead of pluginId, preventing wallet ID overwrites when multiple wallets share the same pluginId.

Or push these changes by commenting:

@cursor push 14928f7cff

Preview (14928f7cff)

diff --git a/src/components/scenes/CreateWalletCompletionScene.tsx b/src/components/scenes/CreateWalletCompletionScene.tsx
--- a/src/components/scenes/CreateWalletCompletionScene.tsx
+++ b/src/components/scenes/CreateWalletCompletionScene.tsx
@@ -56,8 +56,9 @@
   const defaultIsoFiat = useSelector(state => state.ui.settings.defaultIsoFiat)
 
   const [done, setDone] = React.useState(false)
-  const [createdWalletIdsByPluginId, setCreatedWalletIdsByPluginId] =
-    React.useState<Record<string, string>>({})
+  const [createdWalletIdsByKey, setCreatedWalletIdsByKey] = React.useState<
+    Record<string, string>
+  >({})
 
   const { newWalletItems, newTokenItems } = React.useMemo(
     () => splitCreateWalletItems(createWalletList),
@@ -157,13 +158,12 @@
       }
 
       // Save the created wallets
-      const newCreatedWalletIdsByPluginId: Record<string, string> = {}
+      const newCreatedWalletIdsByKey: Record<string, string> = {}
       walletResults.forEach((result, index) => {
         if (!result.ok) return
-        newCreatedWalletIdsByPluginId[newWalletItems[index].pluginId] =
-          result.result.id
+        newCreatedWalletIdsByKey[newWalletItems[index].key] = result.result.id
       })
-      setCreatedWalletIdsByPluginId(newCreatedWalletIdsByPluginId)
+      setCreatedWalletIdsByKey(newCreatedWalletIdsByKey)
 
       setDone(true)
       return () => {}
@@ -264,7 +264,8 @@
 
       return {
         ...createWallet,
-        createWalletId: createdWalletIdsByPluginId[pluginId] ?? '',
+        createWalletId:
+          createdWalletIdsByKey[parentWalletItem?.key ?? key] ?? '',
         walletType: parentWalletItem?.walletType ?? createWallet.walletType,
         displayName:
           parentWalletItem == null

_{This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.}

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix prepared a fix for the issue found in the latest run.

• ✅ Fixed: Double successCount increment in makeMaxSpend path
  • Removed the redundant successCount++ at line 278 to make both makeMaxSpend and legacy paths increment successCount consistently only once per successful bundle.

Or push these changes by commenting:

@cursor push a855b7e9e0

Preview (a855b7e9e0)

diff --git a/src/components/scenes/MigrateWalletCalculateFeeScene.tsx b/src/components/scenes/MigrateWalletCalculateFeeScene.tsx
--- a/src/components/scenes/MigrateWalletCalculateFeeScene.tsx
+++ b/src/components/scenes/MigrateWalletCalculateFeeScene.tsx
@@ -274,8 +274,6 @@
                     item.tokenId == null ? txFee : 'included'
                   )
                 }
-
-                successCount++
               } catch (e: any) {
                 for (const key of bundlesFeeTotals.keys()) {
                   const insufficientFundsError =

_{This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit b4ec9dc. Configure here.}

[cursor]

Double successCount increment in makeMaxSpend path

Low Severity

In the makeMaxSpend branch, successCount is incremented at line 278 inside the spend routine on success, and then incremented again at line 361 after the routine completes (because bundlesFeeTotals contains non-Error values like fee strings and 'included', so the success check passes). The legacy (else) branch only increments at line 361. This double counting is a logic error, though current impact is minimal since the only consumer checks successCount > 0.

Additional Locations (1)

• src/components/scenes/MigrateWalletCalculateFeeScene.tsx#L357-L361

 

^{Reviewed by Cursor Bugbot for commit b4ec9dc. Configure here.}