fix: support union type in as_doc_function_type#1013
Open
EfveZombie wants to merge 1 commit intoEmmyLuaLs:mainfrom
Open
fix: support union type in as_doc_function_type#1013EfveZombie wants to merge 1 commit intoEmmyLuaLs:mainfrom
EfveZombie wants to merge 1 commit intoEmmyLuaLs:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request improves type inference for overloaded functions by updating as_doc_function_type to handle LuaType::Union variants and adds regression tests for pcall scenarios. The reviewer provided a performance optimization suggestion to avoid unnecessary cloning when iterating over union members by matching on the LuaUnionType variants directly, which I have included in the feedback.
crates/emmylua_code_analysis/src/semantic/generic/instantiate_type/instantiate_func_generic.rs
Outdated
Show resolved
Hide resolved
EfveZombie
force-pushed
the
fix.union-type-doc-function
branch
from
b13608c to
713aa46
Compare
…call return types with overloaded members
EfveZombie
force-pushed
the
fix.union-type-doc-function
branch
from
713aa46 to
98231c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support union types in
as_doc_function_type, enabling correctpcallreturn type inference when the callee has overloaded members.