Open
Conversation
1. 类型默认为 public 2. 添加 internal 可见性修饰符, 即包内可见, 在这里包的概念是`workspace.library`引入的内容 3. 删除 ---@export
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces significant changes to the EmmyLua analysis engine, including a new module visibility system, improved workspace path configuration, and a new diagnostic check for inconsistent type access modifiers. The export tag has been removed in favor of a more robust visibility system. I have reviewed the changes and suggest removing the commented-out code block in crates/emmylua_code_analysis/src/compilation/analyzer/doc/property_tags.rs to maintain code cleanliness.
Comment on lines
+28
to
+38
| // 返回变量不能附加可见性 | ||
| // LuaExpr::NameExpr(name_expr) => { | ||
| // let name = name_expr.get_name_text()?; | ||
| // let tree = analyzer | ||
| // .db | ||
| // .get_decl_index() | ||
| // .get_decl_tree(&analyzer.file_id)?; | ||
| // let decl = tree.find_local_decl(&name, name_expr.get_position())?; | ||
|
|
||
| // Some(LuaSemanticDeclId::LuaDecl(decl.get_id())) | ||
| // } |
Contributor
There was a problem hiding this comment.
This block of code is commented out. If it's no longer needed, it should be removed to improve code clarity.
This was referenced Apr 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
constructor特性第四个参数从return_self更改为return_mode以支持返回值使用泛型