Skip to content

Document retention policy for apartments outside strict canton boundaries#8

Draft
Copilot wants to merge 2 commits intomainfrom
copilot/fix-apartments-location-issue
Draft

Document retention policy for apartments outside strict canton boundaries#8
Copilot wants to merge 2 commits intomainfrom
copilot/fix-apartments-location-issue

Conversation

Copy link
Copy Markdown

Copilot AI commented Dec 13, 2025

13 apartments fall slightly outside strict Canton Sarajevo geographic boundaries when plotted but have valid municipality data. Decision: retain all.

Changes

Documentation Added

  • data/README.md: Policy documentation with retention rationale

    • Source filtering: scraped with canton=9 parameter
    • Valid municipalities: all map to Canton Sarajevo administrative units
    • Boundary misalignment: GIS shapefiles don't perfectly match administrative/market boundaries
    • ML considerations: municipality categorical feature more reliable than geocoded coordinates
  • notebooks/scraping_flats_olx.ipynb: Appended markdown cell explaining geographic boundary policy

  • README.md: Added Data Quality Notes section referencing detailed documentation

Verification

No code filters apartments by geographic boundaries—13 apartments retained by default. All have complete feature sets and valid Canton Sarajevo municipalities (Novi Grad, Centar, Novo Sarajevo, Ilidža, Trnovo, Vogošća, Ilijaš).

Affected Records

Example entries (indices 14, 40, 47, 68, 107, 121, 323, 324, 326, 381) showing mix of rent/sale listings with standard feature completeness.

Original prompt

This section details on the original issue you should resolve

<issue_title>Some apartments seem not to be located in Canton Sarajevo</issue_title>
<issue_description>I have attached an image explaining the entire case, on the left can be seen the picture of the apartment distribution and on the right the same distribution just clipped out those which do not fit the scenario

Image

And here is the information detailing the apartments "out of bounds"

Image

there is 13 of them but they all seem to be valid entries and their municipality does match to around where they were deleted. I am unsure if I should keep them or not. I am leaning more towards keeping them but some feedback wont hurt.</issue_description>

Comments on the Issue (you are @copilot in this section)


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: EmreArapcicUevak <90074488+EmreArapcicUevak@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix issue with apartments not located in Canton Sarajevo Document retention policy for apartments outside strict canton boundaries Dec 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some apartments seem not to be located in Canton Sarajevo

2 participants