Skip to content

Unwrap value in isObservableArray#17

Merged
ErikSchierboom merged 3 commits intoErikSchierboom:masterfrom
marcovdb:patch-1
Aug 2, 2016
Merged

Unwrap value in isObservableArray#17
ErikSchierboom merged 3 commits intoErikSchierboom:masterfrom
marcovdb:patch-1

Conversation

@marcovdb
Copy link
Copy Markdown
Contributor

@marcovdb marcovdb commented Jul 31, 2016

This will allow the extender to work on a computed observable as well (as long at it's an array, which makes sense).

This will allow the extender to work on a computed observable as well.
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-1.2%) to 96.429% when pulling 9d1ec68 on marcovdb:patch-1 into 162882f on ErikSchierboom:master.

@guilhermewaess
Copy link
Copy Markdown
Contributor

guilhermewaess commented Jul 31, 2016

@marcovdb Nice work, by the way looks like you can write some tests for this feature, what you think? ;)
But is just a advise <- this turns more easy to @ErikSchierboom accept the PR

@ErikSchierboom
Copy link
Copy Markdown
Owner

@marcovdb Love it! As @guilhermewaess mentioned, having one or more tests for this feature would be super helpful. Would you be willing to add a test?

@marcovdb
Copy link
Copy Markdown
Contributor Author

marcovdb commented Aug 1, 2016

Admittedly I don't have much experience with automated tests, but I'll see what I can do!

@ErikSchierboom
Copy link
Copy Markdown
Owner

@marcovdb Just give me a shout if you need any help!

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-2.2%) to 95.402% when pulling da103c2 on marcovdb:patch-1 into 162882f on ErikSchierboom:master.

@marcovdb
Copy link
Copy Markdown
Contributor Author

marcovdb commented Aug 1, 2016

Okay, I added a few unit tests. I'm not sure why this has actually decreased the coverage but as I said, I'm kind of new at this.

@ErikSchierboom ErikSchierboom merged commit e6a6970 into ErikSchierboom:master Aug 2, 2016
@ErikSchierboom
Copy link
Copy Markdown
Owner

@marcovdb Thanks for adding the tests. This is great work! I've just merged this PR and released a new version (0.4.0) that includes this improvement. Thanks again!

@marcovdb marcovdb deleted the patch-1 branch October 31, 2016 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants