Unwrap value in isObservableArray#17
Unwrap value in isObservableArray#17ErikSchierboom merged 3 commits intoErikSchierboom:masterfrom marcovdb:patch-1
Conversation
This will allow the extender to work on a computed observable as well.
|
@marcovdb Nice work, by the way looks like you can write some tests for this feature, what you think? ;) |
|
@marcovdb Love it! As @guilhermewaess mentioned, having one or more tests for this feature would be super helpful. Would you be willing to add a test? |
|
Admittedly I don't have much experience with automated tests, but I'll see what I can do! |
|
@marcovdb Just give me a shout if you need any help! |
|
Okay, I added a few unit tests. I'm not sure why this has actually decreased the coverage but as I said, I'm kind of new at this. |
|
@marcovdb Thanks for adding the tests. This is great work! I've just merged this PR and released a new version (0.4.0) that includes this improvement. Thanks again! |
This will allow the extender to work on a computed observable as well (as long at it's an array, which makes sense).