Use object shorthand for properties#170
Closed
LinusU wants to merge 1 commit intoEvanHahn:masterfrom
Closed
Conversation
58 tasks
EvanHahn
requested changes
Apr 26, 2020
Owner
EvanHahn
left a comment
EvanHahn
left a comment
There was a problem hiding this comment.
I like this but I want to make sure this library works in old browsers without transpilation, so I don't think I can accept this.
Author
|
Absolutely, sorry for missing that this was meant to be used untranspiled for browsers 👍 I'll keep this in mind if we maybe want to add a way to indicate support for older environments, and in that case not enforce the rule |
Owner
|
No worries at all! Thanks for the work.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This rule is on its way into the latest Standard☺️
ref: standard/eslint-config-standard#166