[HOLD for payment 2025-01-28] [$250] Offline indicator is not displayed at the bottom in the Get physical card page

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.77-6
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @DylanDylann
Slack conversation (hyperlinked to channel name): expensify_bugs

Action Performed:

1. Go to workspace with enable Expensify Card
2. Assign a physical card to a member
3. Login with the member who gets assigned card in step 2
4. Go to Settings -> Wallet -> Assigned Cards
5. Click on the Get Physical card button
6. Go to offline

Expected Result:

Offline indicator should be displayed at the bottom

Actual Result:

Offline indicator is not displayed at the bottom

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Screen.Recording.2024-12-20.at.11.01.27.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021874229543926888067
• Upwork Job ID: 1874229543926888067
• Last Price Increase: 2024-12-31
• Automatic offers:
• DylanDylann | Reviewer | 105629975
• daledah | Contributor | 105629977

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @anmurali

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Offline indicator is not displayed at the bottom in the Get physical card page

What is the root cause of that problem?

We are setting shouldShowOfflineIndicator={false} here

App/src/pages/settings/Wallet/Card/BaseGetPhysicalCard.tsx

Line 187 in 653af04

shouldShowOfflineIndicator={false}

What changes do you think we should make in order to solve the problem?

Simply we can remove this line

App/src/pages/settings/Wallet/Card/BaseGetPhysicalCard.tsx

Line 187 in 653af04

shouldShowOfflineIndicator={false}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[DylanDylann]

@anmurali I reported this bug, could I take over this issue as C+?

[melvin-bot]

@anmurali Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@anmurali Still overdue 6 days?! Let's take care of this!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021874229543926888067