Skip to content

Commit ac8f751

Browse files
Merge pull request #631 from JordanMartinez/cleanup
Insure all public methods are overridden in interface; move interfaces to view package
2 parents c41ea98 + 1e550d9 commit ac8f751

26 files changed

Lines changed: 337 additions & 138 deletions

richtextfx-demos/src/main/java/org/fxmisc/richtext/demo/TooltipDemo.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
import javafx.stage.Popup;
1010
import javafx.stage.Stage;
1111

12-
import org.fxmisc.richtext.MouseOverTextEvent;
12+
import org.fxmisc.richtext.event.MouseOverTextEvent;
1313
import org.fxmisc.richtext.StyleClassedTextArea;
1414

1515
public class TooltipDemo extends Application {

richtextfx/src/integrationTest/java/org/fxmisc/richtext/api/HitTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
import javafx.geometry.Pos;
88
import javafx.stage.Stage;
99
import org.fxmisc.richtext.InlineCssTextAreaAppTest;
10-
import org.fxmisc.richtext.model.NavigationActions;
10+
import org.fxmisc.richtext.NavigationActions;
1111
import org.junit.Before;
1212
import org.junit.Test;
1313
import org.junit.runner.RunWith;

richtextfx/src/integrationTest/java/org/fxmisc/richtext/api/MouseOverTextDelayTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
import javafx.geometry.Pos;
55
import javafx.stage.Stage;
66
import org.fxmisc.richtext.InlineCssTextAreaAppTest;
7-
import org.fxmisc.richtext.MouseOverTextEvent;
7+
import org.fxmisc.richtext.event.MouseOverTextEvent;
88
import org.junit.Ignore;
99
import org.junit.Test;
1010

richtextfx/src/integrationTest/java/org/fxmisc/richtext/keyboard/DeletionTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
import static javafx.scene.input.KeyCode.BACK_SPACE;
1111
import static javafx.scene.input.KeyCode.DELETE;
1212
import static javafx.scene.input.KeyCode.SHORTCUT;
13-
import static org.fxmisc.richtext.model.NavigationActions.SelectionPolicy.CLEAR;
13+
import static org.fxmisc.richtext.NavigationActions.SelectionPolicy.CLEAR;
1414
import static org.junit.Assert.assertEquals;
1515

1616
@RunWith(NestedRunner.class)

richtextfx/src/main/java/org/fxmisc/richtext/Caret.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ public static enum CaretVisibility {
125125
* This method can be used to achieve the special case of positioning the caret outside or inside the selection,
126126
* as opposed to always being at the boundary. Use with care.
127127
*
128-
* <p><b>Caution:</b> see {@link org.fxmisc.richtext.model.TextEditingArea#getAbsolutePosition(int, int)} to
128+
* <p><b>Caution:</b> see {@link TextEditingArea#getAbsolutePosition(int, int)} to
129129
* know how the column index argument can affect the returned position.</p>
130130
*/
131131
public void moveTo(int paragraphIndex, int columnPosition);

richtextfx/src/main/java/org/fxmisc/richtext/CaretSelectionBind.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
import javafx.beans.value.ObservableValue;
44
import javafx.scene.control.IndexRange;
5-
import org.fxmisc.richtext.model.NavigationActions;
65
import org.fxmisc.richtext.model.StyledDocument;
76

87
import java.text.BreakIterator;
@@ -103,7 +102,7 @@ default void moveTo(int position) {
103102

104103
/**
105104
* Moves the caret to the position returned from
106-
* {@link org.fxmisc.richtext.model.TextEditingArea#getAbsolutePosition(int, int)}
105+
* {@link TextEditingArea#getAbsolutePosition(int, int)}
107106
* and clears any selection.
108107
*/
109108
@Override
@@ -176,7 +175,7 @@ default void moveToNextChar() {
176175
* Selects the given range and moves the caret to either the start of the new selection if the anchor was equal to
177176
* the original start or the end if the anchor was equal to the original end
178177
*
179-
* <p><b>Caution:</b> see {@link org.fxmisc.richtext.model.TextEditingArea#getAbsolutePosition(int, int)} to
178+
* <p><b>Caution:</b> see {@link TextEditingArea#getAbsolutePosition(int, int)} to
180179
* know how the column index argument can affect the returned position.</p>
181180
*/
182181
@Override
@@ -292,7 +291,7 @@ else if(pos >= sel.getEnd())
292291

293292
/**
294293
* Moves the caret to the position returned from
295-
* {@link org.fxmisc.richtext.model.TextEditingArea#getAbsolutePosition(int, int)}.
294+
* {@link TextEditingArea#getAbsolutePosition(int, int)}.
296295
*/
297296
void moveTo(int paragraphIndex, int columnIndex, NavigationActions.SelectionPolicy selectionPolicy);
298297

richtextfx/src/main/java/org/fxmisc/richtext/CaretSelectionBindImpl.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
import javafx.beans.value.ObservableValue;
44
import javafx.geometry.Bounds;
55
import javafx.scene.control.IndexRange;
6-
import org.fxmisc.richtext.model.NavigationActions;
76
import org.fxmisc.richtext.model.StyledDocument;
87
import org.reactfx.Subscription;
98
import org.reactfx.Suspendable;

richtextfx/src/main/java/org/fxmisc/richtext/ClipboardActions.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,10 @@
1515
import javafx.scene.input.DataFormat;
1616

1717
import org.fxmisc.richtext.model.Codec;
18-
import org.fxmisc.richtext.model.EditActions;
1918
import org.fxmisc.richtext.model.ReadOnlyStyledDocument;
2019
import org.fxmisc.richtext.model.SegmentOps;
2120
import org.fxmisc.richtext.model.StyledDocument;
2221
import org.fxmisc.richtext.model.StyledSegment;
23-
import org.fxmisc.richtext.model.TextEditingArea;
2422
import org.reactfx.util.Tuple2;
2523

2624
/**

richtextfx/src/main/java/org/fxmisc/richtext/model/EditActions.java renamed to richtextfx/src/main/java/org/fxmisc/richtext/EditActions.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
package org.fxmisc.richtext.model;
1+
package org.fxmisc.richtext;
22

33
import javafx.scene.control.IndexRange;
4-
import org.fxmisc.richtext.GenericStyledArea;
4+
import org.fxmisc.richtext.model.StyledDocument;
55

66
/**
77
* Specifies actions for editing the content of a {@link TextEditingArea}.

0 commit comments

Comments
 (0)