Insure all public methods are overridden in interface; move interfaces to view package#631
Merged
JordanMartinez merged 6 commits intoFXMisc:masterfrom Oct 27, 2017
JordanMartinez:cleanup
Merged
Insure all public methods are overridden in interface; move interfaces to view package#631JordanMartinez merged 6 commits intoFXMisc:masterfrom JordanMartinez:cleanup
JordanMartinez merged 6 commits intoFXMisc:masterfrom
JordanMartinez:cleanup
Conversation
Contributor
Author
|
Still... part of me wants to put the interfaces into an |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TextEditingAreaand its interfaces were moved back to the view package because it seemed more appropriate for them to be there than the model package, where they seemed to add unnecessary bloat.Also, since #630 refers a developer to the interfaces despite some of the public methods in
GenericStyledAreanot being declared or documented inTextEditingAreaor one of its interfaces, these methods are now declared and documented in those places and overridden inGenericStyledArea.Since two event classes were already in the
utilpackage, and a third event class was still in theviewpackage, these were moved to a neweventpackage where it seemed more logical to put them there and also removes a little bloat in theviewpackage. This leaves theutilpackage open for additional utility classes in the future.Lastly,
_position()comes from #213 but has never been renamed to distinguish its functionality fromposition(). Since it only callsnavigator.position(), which is itself confusing due to the other "navigators" that appear throughout the code or its dependencies, this was renamed to a clearer name. I also removed the middle-man-like method since it's only usage is incurrentLine().