Since paragraph style is applied on a higher level than text style, paragraph style arguments should precede text style arguments. We should make this consistent throughout the code base. This applies to both type parameters and constructor/method parameters. We have had this wrong in most places since the very introduction of paragraph-level styles. Affected classes include StyledTextArea and its subclasses and super-interfaces, StyledTextAreaModel, StyledDocument and its subclasses, Paragraph.
For example,
should be changed to
and the constructor
StyledTextArea(
initialStyle, applyStyle,
initialParagraphStyle, applyParagraphStyle
)should be changed to
StyledTextArea(
initialParagraphStyle, applyParagraphStyle,
initialStyle, applyStyle
)
Since paragraph style is applied on a higher level than text style, paragraph style arguments should precede text style arguments. We should make this consistent throughout the code base. This applies to both type parameters and constructor/method parameters. We have had this wrong in most places since the very introduction of paragraph-level styles. Affected classes include
StyledTextAreaand its subclasses and super-interfaces,StyledTextAreaModel,StyledDocumentand its subclasses,Paragraph.For example,
should be changed to
and the constructor
should be changed to